📊 Bundle size report

_{🤖 This report was generated against 8a141d14f3a14de2e1c4691dad908622f310a9d1}

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 48d25ff:

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4ea5942620567cd58687002b35a471333761b8df (build)

I guess that we don't have DOM typings in this case as this package is Node only.
What is proffered solution in this case @Hotell?

Perf Analysis (@fluentui/react)

No significant results to display.

Perf Analysis (@fluentui/react-northstar)

I guess that we don't have DOM typings in this case as this package is Node only. What is proffered solution in this case @Hotell?

for this scenario you need to add following to tsconfig.lib.json

"compilerOptions": {
    "noEmit": false,
-    "lib": ["ES2019"],
+    "lib": ["DOM","ES2019"],
    "outDir": "dist",
    "declaration": true,
-    "types": ["static-assets", "environment"],
+    "types": ["static-assets", "environment", "inline-style-expand-shorthand"],
    "module": "CommonJS"
  },

ideally the generator should check if a node library has web library as dependency and set those accordingly.

from experience this is a corner case and shouldn't happen - instead dependencies should be decoupled into separate libraries so we can have dep graph like following:

I guess that we don't have DOM typings in this case as this package is Node only. What is proffered solution in this case @Hotell?

for this scenario you need to add following to tsconfig.lib.json

"compilerOptions": {
    "noEmit": false,
-    "lib": ["ES2019"],
+    "lib": ["DOM","ES2019"],
    "outDir": "dist",
    "declaration": true,
-    "types": ["static-assets", "environment"],
+    "types": ["static-assets", "environment", "inline-style-expand-shorthand"],
    "module": "CommonJS"
  },

ideally the generator should check if a node library has web library as dependency and set those accordingly.

from experience this is a corner case and shouldn't happen - instead dependencies should be decoupled into separate libraries so we can have dep graph like following:

Thanks! Was thinking about the same, but was not sure that it's acceptable solution 👍